Skip to content

Fix ImageBrowserView combos popup transparency #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

Fix ImageBrowserView combos popup transparency #2094

merged 1 commit into from
Nov 4, 2025

Conversation

@akurtakov
Copy link
Member

@akurtakov akurtakov commented Nov 4, 2025

On Fedora 43 system SWT.COLOR_LIST_BACKGROUND comes with transparency set and this misrenders combos popup as the color is inherited by children. Not setting any color at all is the simplest and most naturally fitting choice to fix the problem.

@akurtakov
Copy link
Member Author

akurtakov commented Nov 4, 2025 •
edited
Loading

Before:
Screenshot From 2025-11-04 18-50-09

After:
image

@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Test Results

  514 files    514 suites   34m 53s ⏱️
3 633 tests 3 579 ✅  54 💤 0 ❌
7 222 runs  7 113 ✅ 109 💤 0 ❌

Results for commit eb1d82b.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member Author

akurtakov commented Nov 4, 2025 

Failed to execute goal org.eclipse.tycho:tycho-p2-plugin:5.0.1-SNAPSHOT:p2-metadata-default (default-p2-metadata-default) on project org.eclipse.pde.doc.user: baseline and build artifacts have same version but different contents

20:21:28  [ERROR]    no-classifier: different

20:21:28  [ERROR]       reference/api/deprecated-list.html: different

20:21:28  [ERROR]       reference/api/index-files/index-1.html: different

20:21:28  [ERROR]       reference/api/org/eclipse/pde/core/plugin/PluginRegistry.PluginFilter.html: different

20:21:28  [ERROR]       reference/api/org/eclipse/pde/core/plugin/class-use/IPluginModelBase.html: different

20:21:28  [ERROR] -> [Help 1]

should be fixed once we rebase on top of #2095

@akurtakov
Fix ImageBrowserView combos popup transparency
eb1d82b 
On Fedora 43 system SWT.COLOR_LIST_BACKGROUND comes with transparency
set and this misrenders combos popup as the color is inherited by
children. Not setting any color at all is the simplest and most
naturally fitting choice to fix the problem.
@akurtakov
Copy link
Member Author

akurtakov commented Nov 4, 2025

Merge despite Mac tests not starting due to brownout of Mac 13.

@akurtakov akurtakov merged commit 668886e into eclipse-pde:master Nov 4, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@akurtakov